coryHawkvelt/gatehouse-api
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: remove redundant unique constraints on id columns from all migrations

Browse Source 
Remove UniqueConstraint('id') from all create_table calls in the initial
migration (40 occurrences) and the bulk constraint additions from the
superadmin migration (43 create + 43 drop). These were redundant with
PrimaryKeyConstraint('id') which already guarantees uniqueness.

Also removes duplicate unique enforcement on superadmins.email and
superadmin_sessions.token (kept the unique indexes, dropped the
table-level UniqueConstraints).

Fixes the root cause in BaseModel by removing unique=True from the id
column definition, which was causing Alembic autogenerate to produce
these redundant constraints.

Renames idx_cert_audit_org to ix_certificate_audit_logs_organization_id
to follow Alembic naming conventions.
This commit is contained in:
Cory Hawkvelt
2026-04-26 06:41:33 +00:00
parent 0fb98b4b38
commit adfeb1bd0f
4 changed files with 27 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files
migrations/versions/b4cd6c6b3b1c_superadmin.py
-95
View File
@@ -30,7 +30,6 @@ def upgrade():
sa.Column('updated_at', sa.DateTime(), nullable=False),
sa.Column('deleted_at', sa.DateTime(), nullable=True),
sa.PrimaryKeyConstraint('id'),
sa.UniqueConstraint('email'),
)
op.create_index(op.f('ix_superadmins_email'), 'superadmins', ['email'], unique=True)
@@ -50,7 +49,6 @@ def upgrade():
sa.Column('deleted_at', sa.DateTime(), nullable=True),
sa.ForeignKeyConstraint(['superadmin_id'], ['superadmins.id']),
sa.PrimaryKeyConstraint('id'),
sa.UniqueConstraint('token'),
)
op.create_index(op.f('ix_superadmin_sessions_superadmin_id'), 'superadmin_sessions', ['superadmin_id'])
op.create_index(op.f('ix_superadmin_sessions_token'), 'superadmin_sessions', ['token'], unique=True)
@@ -83,101 +81,8 @@ def upgrade():
op.create_index(op.f('ix_superadmin_audit_logs_org_id'), 'superadmin_audit_logs', ['org_id'])
op.create_index(op.f('ix_superadmin_audit_logs_user_id'), 'superadmin_audit_logs', ['user_id'])
# ### commands auto generated by Alembic - please adjust! ###
# Add unique constraints on id columns for all existing tables
op.create_unique_constraint(None, 'activation_sessions', ['id'])
op.create_unique_constraint(None, 'application_provider_configs', ['id'])
op.create_unique_constraint(None, 'audit_logs', ['id'])
op.create_unique_constraint(None, 'authentication_methods', ['id'])
op.create_unique_constraint(None, 'ca_permissions', ['id'])
op.create_unique_constraint(None, 'cas', ['id'])
op.create_unique_constraint(None, 'certificate_audit_logs', ['id'])
op.create_unique_constraint(None, 'department_cert_policies', ['id'])
op.create_unique_constraint(None, 'department_memberships', ['id'])
op.create_unique_constraint(None, 'department_principals', ['id'])
op.create_unique_constraint(None, 'departments', ['id'])
op.create_unique_constraint(None, 'device_network_memberships', ['id'])
op.create_unique_constraint(None, 'devices', ['id'])
op.create_unique_constraint(None, 'email_verification_tokens', ['id'])
op.create_unique_constraint(None, 'external_provider_configs', ['id'])
op.create_unique_constraint(None, 'kill_switch_events', ['id'])
op.create_unique_constraint(None, 'mfa_policy_compliance', ['id'])
op.create_unique_constraint(None, 'oauth_states', ['id'])
op.create_unique_constraint(None, 'oidc_audit_logs', ['id'])
op.create_unique_constraint(None, 'oidc_authorization_codes', ['id'])
op.create_unique_constraint(None, 'oidc_clients', ['id'])
op.create_unique_constraint(None, 'oidc_refresh_tokens', ['id'])
op.create_unique_constraint(None, 'oidc_sessions', ['id'])
op.create_unique_constraint(None, 'org_invite_tokens', ['id'])
op.create_unique_constraint(None, 'organization_api_keys', ['id'])
op.create_unique_constraint(None, 'organization_members', ['id'])
op.create_unique_constraint(None, 'organization_provider_overrides', ['id'])
op.create_unique_constraint(None, 'organization_security_policies', ['id'])
op.create_unique_constraint(None, 'organizations', ['id'])
op.create_unique_constraint(None, 'password_reset_tokens', ['id'])
op.create_unique_constraint(None, 'portal_networks', ['id'])
op.create_unique_constraint(None, 'principal_memberships', ['id'])
op.create_unique_constraint(None, 'principals', ['id'])
op.create_unique_constraint(None, 'sessions', ['id'])
op.create_unique_constraint(None, 'ssh_certificates', ['id'])
op.create_unique_constraint(None, 'ssh_keys', ['id'])
op.create_unique_constraint(None, 'superadmin_audit_logs', ['id'])
op.create_unique_constraint(None, 'superadmin_sessions', ['id'])
op.create_unique_constraint(None, 'superadmins', ['id'])
op.create_unique_constraint(None, 'user_network_approvals', ['id'])
op.create_unique_constraint(None, 'user_security_policies', ['id'])
op.create_unique_constraint(None, 'users', ['id'])
op.create_unique_constraint(None, 'zerotier_memberships', ['id'])
# ### end Alembic commands ###
def downgrade():
# ### commands auto generated by Alembic - please adjust! ###
op.drop_constraint(None, 'zerotier_memberships', type_='unique')
op.drop_constraint(None, 'users', type_='unique')
op.drop_constraint(None, 'user_security_policies', type_='unique')
op.drop_constraint(None, 'user_network_approvals', type_='unique')
op.drop_constraint(None, 'superadmins', type_='unique')
op.drop_constraint(None, 'superadmin_sessions', type_='unique')
op.drop_constraint(None, 'superadmin_audit_logs', type_='unique')
op.drop_constraint(None, 'ssh_keys', type_='unique')
op.drop_constraint(None, 'ssh_certificates', type_='unique')
op.drop_constraint(None, 'sessions', type_='unique')
op.drop_constraint(None, 'principals', type_='unique')
op.drop_constraint(None, 'principal_memberships', type_='unique')
op.drop_constraint(None, 'portal_networks', type_='unique')
op.drop_constraint(None, 'password_reset_tokens', type_='unique')
op.drop_constraint(None, 'organizations', type_='unique')
op.drop_constraint(None, 'organization_security_policies', type_='unique')
op.drop_constraint(None, 'organization_provider_overrides', type_='unique')
op.drop_constraint(None, 'organization_members', type_='unique')
op.drop_constraint(None, 'organization_api_keys', type_='unique')
op.drop_constraint(None, 'org_invite_tokens', type_='unique')
op.drop_constraint(None, 'oidc_sessions', type_='unique')
op.drop_constraint(None, 'oidc_refresh_tokens', type_='unique')
op.drop_constraint(None, 'oidc_clients', type_='unique')
op.drop_constraint(None, 'oidc_authorization_codes', type_='unique')
op.drop_constraint(None, 'oidc_audit_logs', type_='unique')
op.drop_constraint(None, 'oauth_states', type_='unique')
op.drop_constraint(None, 'mfa_policy_compliance', type_='unique')
op.drop_constraint(None, 'kill_switch_events', type_='unique')
op.drop_constraint(None, 'external_provider_configs', type_='unique')
op.drop_constraint(None, 'email_verification_tokens', type_='unique')
op.drop_constraint(None, 'devices', type_='unique')
op.drop_constraint(None, 'device_network_memberships', type_='unique')
op.drop_constraint(None, 'departments', type_='unique')
op.drop_constraint(None, 'department_principals', type_='unique')
op.drop_constraint(None, 'department_memberships', type_='unique')
op.drop_constraint(None, 'department_cert_policies', type_='unique')
op.drop_constraint(None, 'certificate_audit_logs', type_='unique')
op.drop_constraint(None, 'cas', type_='unique')
op.drop_constraint(None, 'ca_permissions', type_='unique')
op.drop_constraint(None, 'authentication_methods', type_='unique')
op.drop_constraint(None, 'audit_logs', type_='unique')
op.drop_constraint(None, 'application_provider_configs', type_='unique')
op.drop_constraint(None, 'activation_sessions', type_='unique')
# ### end Alembic commands ###
# --- Drop superadmin tables (reverse order due to FK dependencies) ---
op.drop_index(op.f('ix_superadmin_audit_logs_user_id'), table_name='superadmin_audit_logs')
op.drop_index(op.f('ix_superadmin_audit_logs_org_id'), table_name='superadmin_audit_logs')