From 51b89fb8858e83e142c5077f8d07fb8b35453df3 Mon Sep 17 00:00:00 2001 From: Cory Hawkvelt Date: Mon, 6 Apr 2026 23:50:20 +0930 Subject: [PATCH] refactor(auth): remove redirect_uri from OAuth flow initiation Remove redirect_uri parameter from initiate_login_flow, initiate_register_flow, and initiate_link_flow functions. --- gatehouse_app/api/v1/external_auth/oauth.py | 5 ++--- gatehouse_app/api/v1/external_auth/providers.py | 4 +--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/gatehouse_app/api/v1/external_auth/oauth.py b/gatehouse_app/api/v1/external_auth/oauth.py index a5fea12..33ac85b 100644 --- a/gatehouse_app/api/v1/external_auth/oauth.py +++ b/gatehouse_app/api/v1/external_auth/oauth.py @@ -18,7 +18,6 @@ logger = logging.getLogger(__name__) @api_v1_bp.route("/auth/external//authorize", methods=["GET"]) def initiate_oauth_authorize(provider: str): flow = request.args.get("flow", "login") - redirect_uri = request.args.get("redirect_uri") organization_id = request.args.get("organization_id") oidc_session_id = request.args.get("oidc_session_id") @@ -29,11 +28,11 @@ def initiate_oauth_authorize(provider: str): provider_type = get_provider_type(provider) if flow == "login": auth_url, state = OAuthFlowService.initiate_login_flow( - provider_type=provider_type, organization_id=organization_id, redirect_uri=redirect_uri, + provider_type=provider_type, organization_id=organization_id, ) else: auth_url, state = OAuthFlowService.initiate_register_flow( - provider_type=provider_type, organization_id=organization_id, redirect_uri=redirect_uri, + provider_type=provider_type, organization_id=organization_id, ) if oidc_session_id: diff --git a/gatehouse_app/api/v1/external_auth/providers.py b/gatehouse_app/api/v1/external_auth/providers.py index cd078c0..b269844 100644 --- a/gatehouse_app/api/v1/external_auth/providers.py +++ b/gatehouse_app/api/v1/external_auth/providers.py @@ -171,13 +171,11 @@ def initiate_link_account(provider: str): user_orgs = g.current_user.get_organizations() organization_id = user_orgs[0].id if user_orgs else None - data = request.json or {} - redirect_uri = data.get("redirect_uri") try: auth_url, state = ExternalAuthService.initiate_link_flow( user_id=g.current_user.id, provider_type=provider_type, - organization_id=organization_id, redirect_uri=redirect_uri, + organization_id=organization_id, ) return api_response(data={"authorization_url": auth_url, "state": state}, message="Link flow initiated. Redirect to authorization URL.") except ExternalAuthError as e: